Skip to content

sync: from linuxdeepin/dde-session-shell#442

Merged
yixinshark merged 1 commit into
masterfrom
sync-pr-24-nosync
Jul 11, 2025
Merged

sync: from linuxdeepin/dde-session-shell#442
yixinshark merged 1 commit into
masterfrom
sync-pr-24-nosync

Conversation

@deepin-ci-robot

@deepin-ci-robot deepin-ci-robot commented Jul 11, 2025 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#24

Summary by Sourcery

Sync inhibit warning view pixmap handling to remove device pixel ratio scaling for button icons

Bug Fixes:

  • Remove devicePixelRatioF-based scaling when generating Accept button normal and hover pixmaps
  • Remove devicePixelRatioF-based scaling when generating Cancel button normal and hover pixmaps

@sourcery-ai

sourcery-ai Bot commented Jul 11, 2025

Copy link
Copy Markdown

Reviewer's Guide

Replaced devicePixelRatioF-based pixmap scaling with direct iconSize for accept and cancel button icons to simplify size handling.

File-Level Changes

Change Details Files
Remove devicePixelRatioF scaling when setting normal and hover pixmaps for buttons.
  • Use pixmap(iconSize) instead of pixmap(iconSize * devicePixelRatioF()) for accept button normal pixmap
  • Use pixmap(iconSize) instead of pixmap(iconSize * devicePixelRatioF()) for accept button hover pixmap
  • Use pixmap(iconSize) instead of pixmap(iconSize * devicePixelRatioF()) for cancel button normal pixmap
  • Use pixmap(iconSize) instead of pixmap(iconSize * devicePixelRatioF()) for cancel button hover pixmap
 src/widgets/inhibitwarnview.cpp
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot reviewed Jul 11, 2025
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
sync: from linuxdeepin/dde-session-shell
6e52926 
Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#24
@deepin-ci-robot

deepin-ci-robot commented Jul 11, 2025

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

代码审查意见：

.reuse/dep5 文件

  • 新增文件扩展名: 在 .reuse/dep5 文件中新增了 .syncexclude 文件扩展名。请确认这是否是必要的，以及是否有相应的文档或注释说明为什么需要这个文件扩展名。

src/widgets/inhibitwarnview.cpp 文件

  • 图标大小调整: 在 InhibitWarnView::initUi() 方法中，将 acceptIcon 和 iconCancelNormal 的图标大小调整从使用 devicePixelRatioF() 方法改为直接使用 iconSize。这可能会影响图标在不同设备上的显示效果。建议确认这一改动是否符合设计要求，并确保所有设备上的图标显示都是正确的。

  • 代码重复: acceptIcon 和 iconCancelNormal 的图标大小调整代码是重复的，可以考虑将这部分代码提取到一个单独的函数中，以减少代码重复和提高代码的可维护性。

  • 缺少注释: 新增的代码没有添加注释说明为什么需要调整图标大小，或者为什么选择使用 iconSize 而不是 iconSize * devicePixelRatioF()。添加适当的注释可以帮助其他开发者理解代码的意图和背景。

总体来说，代码的改动看起来是合理的，但是需要确保这些改动不会影响应用程序的功能和用户体验。

@deepin-ci-robot

deepin-ci-robot commented Jul 11, 2025

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit 6a85287 into master Jul 11, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@yixinshark yixinshark yixinshark approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deepin-ci-robot @yixinshark